szaszm commented on code in PR #1725:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1514353106
##########
libminifi/include/core/ProcessGroup.h:
##########
@@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent {
*/
std::shared_ptr<core::controller::ControllerServiceNode>
findControllerService(const std::string &nodeId) const;
+ std::vector<std::shared_ptr<core::controller::ControllerServiceNode>>
getAllControllerServices() const;
Review Comment:
I'm assuming they can't be null, so I think it would be nicer to wrap the
pointers in not_null. Or have runtime checks more graceful than gsl_Expects if
they can be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
