scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1538270150
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/state/access-policy/access-policy.effects.ts:
##########
@@ -172,7 +173,7 @@ export class AccessPolicyEffects {
concatLatestFrom(() =>
this.store.select(selectAccessPolicy).pipe(isDefinedAndNotNull())),
tap(([, accessPolicy]) => {
const dialogReference =
this.dialog.open(OverridePolicyDialog, {
- panelClass: 'small-dialog'
+ ...DIALOG_SIZES.LARGE
Review Comment:
It was just a personal preference. I thought having the instructions on a
single line was easier to comprehend and it made it more clear to the user that
they need to select either the "Copy" or the "Empty" policy will be the default:
Previously:
<img width="1728" alt="Screenshot 2024-03-25 at 5 36 47 PM"
src="https://github.com/apache/nifi/assets/6797571/a535ad0b-9b3c-4ac3-b7e8-7a59dcccc0d4";>
If we make this a large dialog maybe it is more clear to the user what to do:
<img width="1726" alt="Screenshot 2024-03-25 at 5 36 12 PM"
src="https://github.com/apache/nifi/assets/6797571/24a2c066-0db8-485f-a03d-ea193e7dec40";>
Please let me know your thoughts here. I can easily restore the small dialog
if you think it is appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
