scottyaslan commented on code in PR #8535: URL: https://github.com/apache/nifi/pull/8535#discussion_r1538282376
########## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.html: ########## @@ -15,8 +15,8 @@ ~ limitations under the License. --> -<div class="parameter-table flex gap-x-3"> - <div class="flex flex-col gap-y-3"> +<div class="parameter-table grid-container grid grid-cols-3"> + <div class="col-span-2 pr-5"> Review Comment: I could have used flex for this element but then I needed to assign a width to at least one of (and likely it should be both) the listing table and the referencing components elements. Instead I opted to use the grid to give 2/3 width to the parameter listing table and leave 1/3 of the space to the referencing components container element. I think either approach is appropriate here but let me know if you think we need to make a change here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
