scottyaslan commented on code in PR #8535:
URL: https://github.com/apache/nifi/pull/8535#discussion_r1539869502
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/yes-no-dialog/yes-no-dialog.component.html:
##########
@@ -17,7 +17,7 @@
<h2 mat-dialog-title data-qa="yes-no-title">{{ request.title }}</h2>
<mat-dialog-content>
- <div class="text-sm max-w-sm" data-qa="yes-no-message">{{ request.message
}}</div>
Review Comment:
Ok, here is the current approach:
- YesNoDialog's are now all SMALL_DIALOG's now which get the `max-width:
24rem`.
- OkDialogs can be any size dialog but should also have `maxWidth: '24rem'`
override when opening the dialog
- Cancel dialog messages are controlled by the frontend and are small. No
dialog size or max width are set on these
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
