szaszm commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1559357442
##########
PROCESSORS.md:
##########
@@ -1548,7 +1548,7 @@ In the list below, the names of required properties
appear in bold. Any other pr
### Description
-Listens for incoming TCP connections and reads data from each connection using
a line separator as the message demarcator. For each message the processor
produces a single FlowFile.
+Listens for incoming TCP connections and reads data from each connection using
a configurable message demarcator. For each message the processor produces a
single FlowFile.
Review Comment:
We should call it either delimiter or demarcator consistently.
```suggestion
Listens for incoming TCP connections and reads data from each connection
using a configurable message delimiter. For each message the processor produces
a single FlowFile.
```
##########
extensions/standard-processors/processors/ListenTCP.h:
##########
@@ -69,15 +69,29 @@ class ListenTCP : public NetworkListenerProcessor {
.withDefaultValue(magic_enum::enum_name(utils::net::ClientAuthOption::NONE))
.withAllowedValues(magic_enum::enum_names<utils::net::ClientAuthOption>())
.build();
- EXTENSIONAPI static constexpr auto Properties =
std::array<core::PropertyReference, 5>{
+ EXTENSIONAPI static constexpr auto MessageDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Message Delimiter")
+ .withDescription("The delimiter is used to divide the stream into
flowfiles.")
+ .isRequired(true)
+ .withDefaultValue("\n")
+ .supportsExpressionLanguage(false)
+ .build();
+ EXTENSIONAPI static constexpr auto ConsumeDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Consume delimiter")
Review Comment:
```suggestion
EXTENSIONAPI static constexpr auto ConsumeDelimiter =
core::PropertyDefinitionBuilder<>::createProperty("Consume Delimiter")
```
##########
PROCESSORS.md:
##########
@@ -1561,6 +1561,8 @@ In the list below, the names of required properties
appear in bold. Any other pr
| **Max Size of Message Queue** | 10000 | |
Maximum number of messages allowed to be buffered before processing them when
the processor is triggered. If the buffer is full, the message is ignored. If
set to zero the buffer is unlimited. |
| SSL Context Service | | |
The Controller Service to use in order to obtain an SSL Context. If this
property is set, messages will be received over a secure connection.
|
| Client Auth | NONE | NONE<br/>WANT<br/>REQUIRED |
The client authentication policy to use for the SSL Context. Only used if an
SSL Context Service is provided.
|
+| **Message Delimiter** | \n | |
The delimiter is used to divide the stream into flowfiles.
|
+| **Consume delimiter** | true | true<br/>false |
If set to true then the delimiter won't be included at the end of the resulting
flowfiles.
|
Review Comment:
Most properties have capital first letters in each word.
```suggestion
| **Consume Delimiter** | true | true<br/>false
| If set to true then the delimiter won't be included at the end of the
resulting flowfiles.
|
```
##########
extensions/standard-processors/processors/ListenTCP.h:
##########
@@ -36,10 +36,10 @@ namespace org::apache::nifi::minifi::processors {
class ListenTCP : public NetworkListenerProcessor {
public:
explicit ListenTCP(std::string_view name, const utils::Identifier& uuid = {})
- : NetworkListenerProcessor(name, uuid,
core::logging::LoggerFactory<ListenTCP>::getLogger(uuid)) {
+ : NetworkListenerProcessor(name, uuid,
core::logging::LoggerFactory<ListenTCP>::getLogger(uuid)) {
}
- EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a line
separator as the message demarcator. "
+ EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a
configurable message demarcator. "
Review Comment:
```suggestion
EXTENSIONAPI static constexpr const char* Description = "Listens for
incoming TCP connections and reads data from each connection using a
configurable message delimiter. "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
