martinzink commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1560900290
##########
extensions/standard-processors/processors/ListenTCP.cpp:
##########
@@ -28,7 +28,13 @@ void ListenTCP::initialize() {
}
void ListenTCP::onSchedule(core::ProcessContext& context,
core::ProcessSessionFactory&) {
- startTcpServer(context, SSLContextService, ClientAuth);
+ auto delimiter_str = context.getProperty(MessageDelimiter).value_or("\n");
+ if (delimiter_str.empty()) {
+ logger_->log_warn("{} cannot be an empty string", MessageDelimiter.name);
Review Comment:
good idea, ive included this in
https://github.com/apache/nifi-minifi-cpp/pull/1753/commits/0f488acc7ebffe1ac35e1a0924c96b63a15f5eba
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
