fgerlits commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565902422
##########
libminifi/test/unit/CronTests.cpp:
##########
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_DIR);
#endif
- const std::vector<std::string> time_zones{ "Europe/Berlin", "Asia/Seoul",
"America/Los_Angeles", "Asia/Singapore", "UCT" };
+ const std::vector<std::string> time_zones{ "Europe/Berlin", "Asia/Seoul",
"America/Los_Angeles", "Asia/Singapore", "UTC" };
Review Comment:
Continuing to support UCT would be a bigger piece of work, if we want to do
it.
Starting with Ubuntu mantic and Debian trixie (and probably other newer
distros), UCT is no longer a top level time zone in `/usr/share/zoneinfo`, but
an alias to UTC under `/usr/share/zoneinfo/Etc`. The `date` library does not
like aliases: in
[tzdb::locate_zone](https://github.com/HowardHinnant/date/blob/cd3c57932f7f3906c5876b8f04e2ff6b20d2070b/src/tz.cpp#L3730),
it finds that `tz_name` (= "UCT") is different from the name of the time zone
it points to (= "UTC") and it fails.
EDIT: maybe this can be fixed with an update of the date library; let me
give it a go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
