szaszm commented on code in PR #1756:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1756#discussion_r1565961703
##########
libminifi/test/unit/CronTests.cpp:
##########
@@ -421,7 +421,7 @@ TEST_CASE("Cron::calculateNextTrigger with timezones",
"[cron]") {
date::set_install(TZ_DATA_DIR);
#endif
- const std::vector<std::string> time_zones{ "Europe/Berlin", "Asia/Seoul",
"America/Los_Angeles", "Asia/Singapore", "UCT" };
+ const std::vector<std::string> time_zones{ "Europe/Berlin", "Asia/Seoul",
"America/Los_Angeles", "Asia/Singapore", "UTC" };
Review Comment:
If it was just a typo, I'm OK with dropping it. My distro is quite 'new', an
Arch Linux updated last week, and it still has "UCT" under
`/usr/share/zoneinfo` (and also under `Etc`), which is not a symlink, but
identical to "UTC". So I'm guessing it's a debian/ubuntu thing. Either way, the
test should work on those systems.
Updating the date library or moving to the C++20 would be nice, but I'd keep
it separate from this PR. If you're investigating, please share your results,
but I don't want to hold up this PR with the additional change, if it's not
necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
