jrsteinebrey commented on code in PR #7544: URL: https://github.com/apache/nifi/pull/7544#discussion_r1603296706
########## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.db; + +import org.apache.nifi.components.DescribedValue; + +/** + * Enumeration of supported Database column name Translation Strategies + */ +public enum TranslationStrategy implements DescribedValue { + REMOVE_UNDERSCORE("Remove Underscore", + "Underscore(_) will be removed from column name with empty string Ex. Pics_1_11 become PICS111"), Review Comment: I recommend this wording: "Underscores '_' will be removed from column names Ex: 'Pics_1_23' becomes 'PICS123'" ########## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.db; + +import org.apache.nifi.components.DescribedValue; + +/** + * Enumeration of supported Database column name Translation Strategies + */ +public enum TranslationStrategy implements DescribedValue { + REMOVE_UNDERSCORE("Remove Underscore", + "Underscore(_) will be removed from column name with empty string Ex. Pics_1_11 become PICS111"), + REMOVE_SPACE("Remove Space", + "Spaces will be removed from column name with empty string Ex. 'User Name' become 'USERNAME'"), Review Comment: I recommend this wording: "Spaces will be removed from column names Ex. 'User Name' becomes 'USERNAME'" ########## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.db; + +import org.apache.nifi.components.DescribedValue; + +/** + * Enumeration of supported Database column name Translation Strategies + */ +public enum TranslationStrategy implements DescribedValue { + REMOVE_UNDERSCORE("Remove Underscore", + "Underscore(_) will be removed from column name with empty string Ex. Pics_1_11 become PICS111"), + REMOVE_SPACE("Remove Space", + "Spaces will be removed from column name with empty string Ex. 'User Name' become 'USERNAME'"), + REMOVE_ALL_SPECIAL_CHAR("Remove All Special Character", "Remove All Special Character"), + PATTERN("Regular Expression", "Remove character matched Regular Expression from column name"); Review Comment: "Remove characters matching this Regular Expression from the column names" ########## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.db; + +import org.apache.nifi.components.DescribedValue; + +/** + * Enumeration of supported Database column name Translation Strategies + */ +public enum TranslationStrategy implements DescribedValue { + REMOVE_UNDERSCORE("Remove Underscore", + "Underscore(_) will be removed from column name with empty string Ex. Pics_1_11 become PICS111"), + REMOVE_SPACE("Remove Space", + "Spaces will be removed from column name with empty string Ex. 'User Name' become 'USERNAME'"), + REMOVE_ALL_SPECIAL_CHAR("Remove All Special Character", "Remove All Special Character"), Review Comment: Remove All Special Character implies it will remove everything character which is and a-z or 0-9. I think this is more descriptive: "Remove Regular Expression Characters", "Remove Regular Expression Characters" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
