jrsteinebrey commented on code in PR #7544:
URL: https://github.com/apache/nifi/pull/7544#discussion_r1635355735
##########
nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/ColumnDescription.java:
##########
@@ -84,9 +84,6 @@ public static ColumnDescription from(final ResultSet
resultSet) throws SQLExcept
return new ColumnDescription(columnName, dataType, required, colSize
== 0 ? null : colSize, isNullable);
}
- public static String normalizeColumnName(final String colName, final
boolean translateColumnNames) {
- return colName == null ? null : (translateColumnNames ?
colName.toUpperCase().replace("_", "") : colName);
Review Comment:
@mattyb149 GitHub shows you as the author of this line 88 back in 2021 when
you created the ColumnDescription class. Do you feel that the null check is
required here?
Can you think of a use case where colName parameter would be null?
I ask because the replacement code in TableSchema.normalizeName() does NOT
have the null check and I want to see if you or others feel the null check is
worth having in the new code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
