lordgamez commented on code in PR #1805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1624584513


##########
.gitignore:
##########
@@ -65,6 +65,12 @@ __pycache__/
 /provenance_repository
 /logs
 msi/WixWin.wsi
+extensions/expression-language/el-scanner/Scanner.cpp
+extensions/expression-language/el-parser/Parser.cpp
+extensions/expression-language/el-parser/Parser.hpp
+extensions/expression-language/el-parser/location.hh
+extensions/expression-language/el-parser/position.hh
+extensions/expression-language/el-parser/stack.hh

Review Comment:
   In the first draft el-scanner and el-parser directories were not part of the 
repository as they were only created at build time with the generated files. As 
CPPLINT.cfg is now also added in those directories I think you are right, I'll 
add the .gitignore files there as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to