lordgamez commented on code in PR #1805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1625722350
##########
.gitignore:
##########
@@ -65,6 +65,12 @@ __pycache__/
/provenance_repository
/logs
msi/WixWin.wsi
+extensions/expression-language/el-scanner/Scanner.cpp
+extensions/expression-language/el-parser/Parser.cpp
+extensions/expression-language/el-parser/Parser.hpp
+extensions/expression-language/el-parser/location.hh
+extensions/expression-language/el-parser/position.hh
+extensions/expression-language/el-parser/stack.hh
Review Comment:
Updated in be9cace2da1aa161129ac9c22986033dafc199db
##########
libminifi/include/io/CRCStream.h:
##########
@@ -27,6 +27,7 @@
#include <cassert>
#ifdef WIN32
+#pragma warning(disable : 4250)
Review Comment:
Updated in be9cace2da1aa161129ac9c22986033dafc199db
##########
extensions/expression-language/CMakeLists.txt:
##########
@@ -96,20 +96,22 @@ find_package(FLEX REQUIRED)
bison_target(
el-parser
${CMAKE_CURRENT_SOURCE_DIR}/Parser.yy
- ${CMAKE_CURRENT_SOURCE_DIR}/Parser.cpp
+ ${CMAKE_CURRENT_SOURCE_DIR}/el-parser/Parser.cpp
)
flex_target(
el-scanner
${CMAKE_CURRENT_SOURCE_DIR}/Scanner.ll
- ${CMAKE_CURRENT_SOURCE_DIR}/Scanner.cpp
+ ${CMAKE_CURRENT_SOURCE_DIR}/el-scanner/Scanner.cpp
COMPILE_FLAGS --c++
)
add_flex_bison_dependency(el-scanner el-parser)
include_directories(./ ../../libminifi/include ../../libminifi/include/core)
include_directories(SYSTEM ../../thirdparty/)
+include_directories(SYSTEM el-parser)
+include_directories(SYSTEM el-scanner)
Review Comment:
Updated in be9cace2da1aa161129ac9c22986033dafc199db
##########
extensions/opc/src/fetchopc.cpp:
##########
@@ -62,7 +62,7 @@ namespace org::apache::nifi::minifi::processors {
if (idType_ == opc::OPCNodeIDType::Int) {
try {
- std::stoi(nodeID_);
+ static_cast<void>(std::stoi(nodeID_));
Review Comment:
Updated in be9cace2da1aa161129ac9c22986033dafc199db
##########
extensions/opc/src/putopc.cpp:
##########
@@ -56,7 +56,7 @@ namespace org::apache::nifi::minifi::processors {
if (idType_ == opc::OPCNodeIDType::Int) {
try {
- std::stoi(nodeID_);
+ static_cast<void>(std::stoi(nodeID_));
Review Comment:
Updated in be9cace2da1aa161129ac9c22986033dafc199db
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]