fgerlits commented on code in PR #1779: URL: https://github.com/apache/nifi-minifi-cpp/pull/1779#discussion_r1668350183
########## libminifi/include/core/Record.h: ########## @@ -30,6 +30,10 @@ class Record { public: Record() = default; Record(Record&& rhs) noexcept : fields_(std::move(rhs.fields_)) {} + Record& operator=(Record&& rhs) noexcept { + fields_ = std::move(rhs.fields_); + return *this; + }; Review Comment: thanks; also :+1: for explicitly deleting the copy constructors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org