martinzink commented on code in PR #1779: URL: https://github.com/apache/nifi-minifi-cpp/pull/1779#discussion_r1679181706
########## extensions/standard-processors/modbus/FetchModbusTcp.cpp: ########## @@ -0,0 +1,274 @@ +/** +* Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "FetchModbusTcp.h" + +#include <utils/net/ConnectionHandler.h> + +#include <asio/read.hpp> +#include <range/v3/view/drop.hpp> Review Comment: you are right 👍 [removed unused header from FetchModbusTcp.cpp](https://github.com/apache/nifi-minifi-cpp/pull/1779/commits/f0beec6f960f6170bdda387c782f99eb96307716) ########## PROCESSORS.md: ########## @@ -935,6 +936,35 @@ In the list below, the names of required properties appear in bold. Any other pr | gcs.error.domain | failure | The domain of the error occurred during operation. | +## FetchModbusTcp + +### Description + +Processor able to read data from industrial PLCs using Modbus TCP/IP + +### Properties + +In the list below, the names of required properties appear in bold. Any other properties (not in bold) are considered optional. The table also indicates any default values, and whether a property supports the NiFi Expression Language. + +| Name | Default Value | Allowable Values | Description | +|--------------------------------|---------------|------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| **Hostname** | | | The ip address or hostname of the destination.<br/>**Supports Expression Language: true** | +| **Port** | 502 | | The port or service on the destination.<br/>**Supports Expression Language: true** | +| **Unit Identifier** | 0 | | The port or service on the destination.<br/>**Supports Expression Language: true** | +| **Idle Connection Expiration** | 15 seconds | | The amount of time a connection should be held open without being used before closing the connection. A value of 0 seconds will disable this feature.<br/>**Supports Expression Language: true** | Review Comment: 👍 good catch, [update PROCESSORS.md](https://github.com/apache/nifi-minifi-cpp/pull/1779/commits/1cb3826d009971b5462c555014172ff36915bd56) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
