joewitt commented on PR #9171: URL: https://github.com/apache/nifi/pull/9171#issuecomment-2282872902
Is this PR intended for Apache NiFI? It appears to fail the build due to usage of internal/fork versions of NiFi components. It appears to be very similar to the second of two PRs previously offered for this JIRA specifically https://github.com/apache/nifi/pull/8498 In that previous PR (8498) a concern was raised and appears to remain which relates to 'previousEventIds'. That comment can be found here https://github.com/apache/nifi/pull/8498#pullrequestreview-1943250066. I echo that concern. I left comments/questions on the previous PR as well. I don't see responses on that PR or the JIRA or any comments in this PR to address those concerns/questions. Possibly I'm just missing where that dialogue happened and if so please direct where it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
