joewitt commented on code in PR #9171:
URL: https://github.com/apache/nifi/pull/9171#discussion_r1713058315
##########
nifi-extension-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/util/StorageSummaryEvent.java:
##########
@@ -19,11 +19,14 @@
import java.util.List;
import java.util.Map;
+import java.util.Set;
+
import org.apache.nifi.provenance.ProvenanceEventRecord;
import org.apache.nifi.provenance.ProvenanceEventType;
+import org.apache.nifi.provenance.UpdateableProvenanceEventRecord;
import org.apache.nifi.provenance.serialization.StorageSummary;
-public class StorageSummaryEvent implements ProvenanceEventRecord {
+public class StorageSummaryEvent implements UpdateableProvenanceEventRecord {
Review Comment:
This change to an 'UpdateableProvenanceEventRecord' abstraction and addition
of setters stands out. What is it about this new concept (previous event
identifiers) that is causing a change in abstraction ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
