markobean commented on PR #9685:
URL: https://github.com/apache/nifi/pull/9685#issuecomment-2634915211

   > Thanks for working on this new Flow Analysis Rule @markobean. I just 
started looking at it. Would it be possible to combine the five 
src/test/resource files that include a violation into one file? Then the unit 
test could configure the rule to only look for one type of violation.
   
   I updated the unit tests to all use a single flow definition file. Due to 
the nature of combining load balancing strategy and compression, some unit 
tests have more than a single connection in violation. I did create static 
variables that are more descriptive of the component in violation. Hopefully, 
it is clear.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to