fgerlits commented on code in PR #1985:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1985#discussion_r2175688673
##########
extensions/windows-event-log/wel/MetadataWalker.h:
##########
@@ -49,11 +49,12 @@ namespace org::apache::nifi::minifi::wel {
*/
class MetadataWalker : public pugi::xml_tree_walker {
public:
- MetadataWalker(const WindowsEventLogMetadata& windows_event_log_metadata,
std::string log_name, bool update_xml, bool resolve, utils::Regex const* regex,
+ MetadataWalker(const WindowsEventLogMetadata& windows_event_log_metadata,
std::string log_name, bool update_xml, bool resolve,
+ const std::function<bool(std::string_view)>& sid_matcher,
std::function<std::string(std::string)> user_id_to_username_fn)
: windows_event_log_metadata_(windows_event_log_metadata),
log_name_(std::move(log_name)),
- regex_(regex),
+ sid_matcher_(sid_matcher),
Review Comment:
done: 6b5801d34539ec0b12a965e64a38ae5647401c4e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
