fgerlits commented on code in PR #1985:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1985#discussion_r2207962415
##########
extensions/windows-event-log/wel/WindowsEventLog.h:
##########
@@ -58,11 +58,39 @@ enum METADATA {
COMPUTER,
UNKNOWN
};
+// this is a continuous enum, so we can rely on the array
Review Comment:
My theory is that it refers to the vector below it, which at some earlier
point may have been an array indexed by enum values treated as integers
(although I haven't found evidence for this in git history).
We should get rid of the `METADATA_NAMES` type together with the
`getMetadataString()` and `getMetadataFromString()` functions, and replace them
by magic_enum calls. But I would prefer to do that separately in a different
pull request, as it is not related to performance improvement.
For now, I have removed this log line:
e359090170445e8f2769b13fa451cfc476af9918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
