Copilot commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2256800022
##########
libminifi/src/core/state/nodes/AgentInformation.cpp:
##########
@@ -76,7 +76,7 @@ void ComponentManifest::serializeClassDescription(const
std::vector<ClassDescrip
utils::string::replaceAll(typeClazz, "::", ".");
allowed_type.children.push_back({.name = "type", .value =
typeClazz});
allowed_type.children.push_back({.name = "group", .value =
GROUP_STR});
- allowed_type.children.push_back({.name = "artifact", .value =
core::ClassLoader::getDefaultClassLoader().getGroupForClass(class_name).value_or("")});
+ allowed_type.children.push_back({.name = "artifact", .value =
core::ClassLoader::getDefaultClassLoader().getGroupForClass(class_name).value_or("minifi-system")});
Review Comment:
The hardcoded fallback value "minifi-system" should be defined as a constant
or retrieved from a centralized configuration to improve maintainability.
```suggestion
allowed_type.children.push_back({.name = "artifact", .value =
core::ClassLoader::getDefaultClassLoader().getGroupForClass(class_name).value_or(DEFAULT_ARTIFACT_GROUP)});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
