fgerlits commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2259766749
##########
extensions/standard-processors/controllers/JsonRecordSetWriter.h:
##########
@@ -83,6 +83,9 @@ class JsonRecordSetWriter final : public
core::RecordSetWriterImpl {
});
EXTENSIONAPI static constexpr bool SupportsDynamicProperties = false;
+ EXTENSIONAPI static constexpr auto ApiImplementations =
std::to_array<core::ControllerServiceApiDefinition>({
+ RecordSetWriter::ControllerServiceApiDefinition
+ });
Review Comment:
since there is no type conversion, these could be shortened to
```suggestion
EXTENSIONAPI static constexpr auto ApiImplementations =
std::array{RecordSetWriter::ControllerServiceApiDefinition};
```
##########
minifi-api/include/minifi-cpp/controllers/RecordSetReader.h:
##########
@@ -30,6 +30,12 @@ namespace org::apache::nifi::minifi::core {
class RecordSetReader : public virtual controller::ControllerService {
public:
+ static constexpr auto ControllerServiceApiDefinition =
core::ControllerServiceApiDefinition{
Review Comment:
something like "ProvidesApi" would be a better name
come to think about it, I would also rename "ApiImplementations" to
"ImplementsApis", but I feel less strongly about that
##########
libminifi/include/controllers/SSLContextService.h:
##########
@@ -72,20 +72,20 @@ class SSLContext {
* Justification: Abstracts SSL support out of processors into a
* configurable controller service.
*/
-class SSLContextServiceImpl : public core::controller::ControllerServiceImpl,
public SSLContextService {
+class SSLContextService : public core::controller::ControllerServiceImpl,
public SSLContextServiceInterface {
public:
- explicit SSLContextServiceImpl(std::string_view name, const
utils::Identifier &uuid = {})
+ explicit SSLContextService(std::string_view name, const utils::Identifier
&uuid = {})
: ControllerServiceImpl(name, uuid),
initialized_(false),
-
logger_(core::logging::LoggerFactory<SSLContextService>::getLogger(uuid_)) {
+
logger_(core::logging::LoggerFactory<SSLContextServiceInterface>::getLogger(uuid_))
{
Review Comment:
we should keep the class name in the log as "SSLContextService" (also in
line 86)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
