martinzink commented on code in PR #2001:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2001#discussion_r2260175456
##########
libminifi/include/controllers/SSLContextService.h:
##########
@@ -72,20 +72,20 @@ class SSLContext {
* Justification: Abstracts SSL support out of processors into a
* configurable controller service.
*/
-class SSLContextServiceImpl : public core::controller::ControllerServiceImpl,
public SSLContextService {
+class SSLContextService : public core::controller::ControllerServiceImpl,
public SSLContextServiceInterface {
public:
- explicit SSLContextServiceImpl(std::string_view name, const
utils::Identifier &uuid = {})
+ explicit SSLContextService(std::string_view name, const utils::Identifier
&uuid = {})
: ControllerServiceImpl(name, uuid),
initialized_(false),
-
logger_(core::logging::LoggerFactory<SSLContextService>::getLogger(uuid_)) {
+
logger_(core::logging::LoggerFactory<SSLContextServiceInterface>::getLogger(uuid_))
{
Review Comment:
good catch and I agree, but to be fair it was like this previously aswell
(Impl used Interface logger)
changed it
https://github.com/apache/nifi-minifi-cpp/pull/2001/commits/b714eb903d50d1359832004904777dd6d296a912
##########
minifi-api/include/minifi-cpp/controllers/RecordSetReader.h:
##########
@@ -30,6 +30,12 @@ namespace org::apache::nifi::minifi::core {
class RecordSetReader : public virtual controller::ControllerService {
public:
+ static constexpr auto ControllerServiceApiDefinition =
core::ControllerServiceApiDefinition{
Review Comment:
👍 you wanna rename only the member or the struct aswell?
renamed the member
https://github.com/apache/nifi-minifi-cpp/pull/2001/commits/b714eb903d50d1359832004904777dd6d296a912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
