martinzink commented on code in PR #2077:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2077#discussion_r2717518347
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -61,6 +60,9 @@ def step_impl(context: MinifiTestContext, processor_type:
str, property_name: st
def step_impl(context: MinifiTestContext, processor_type: str, property_name:
str, property_value: str, minifi_container_name: str):
processor = Processor(processor_type, processor_type)
processor.add_property(property_name, property_value)
+ if minifi_container_name == "nifi":
+ context.containers["nifi"].flow_definition.add_processor(processor)
+ return
Review Comment:
what if we were to instead modify the steps so its explicit that its the
nifi flow so we dont have to do this `if minifi_container_name == "nifi"`
e.g.
And a ListenHTTP processor with the "Listening Port" property set to "8081"
in NiFi
instead of the current
And a ListenHTTP processor with the "Listening Port" property set to "8081"
in the "nifi" flow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
