lordgamez commented on code in PR #2077:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2077#discussion_r2727545576
##########
behave_framework/src/minifi_test_framework/steps/flow_building_steps.py:
##########
@@ -61,6 +60,9 @@ def step_impl(context: MinifiTestContext, processor_type:
str, property_name: st
def step_impl(context: MinifiTestContext, processor_type: str, property_name:
str, property_value: str, minifi_container_name: str):
processor = Processor(processor_type, processor_type)
processor.add_property(property_name, property_value)
+ if minifi_container_name == "nifi":
+ context.containers["nifi"].flow_definition.add_processor(processor)
+ return
Review Comment:
Updated in
https://github.com/apache/nifi-minifi-cpp/pull/2077/commits/0b4930dd9881ad2b7e30e2ffcbc6e9ce8b65a1f1
In the checking steps I realized there is no need to differentiate the
minifi/nifi containers from other containers so just the container name can be
used there. Otherwise in the flow building steps I created separate steps for
the NiFi flows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
