exceptionfactory commented on code in PR #10852: URL: https://github.com/apache/nifi/pull/10852#discussion_r2765467206
########## nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-service-api/src/main/java/org/apache/nifi/kafka/service/api/common/ConsumerMetrics.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.kafka.service.api.common; + +import org.apache.commons.lang3.builder.ToStringBuilder; + +import java.util.OptionalLong; + +public class ConsumerMetrics { + + private final static ConsumerMetrics EMPTY = new ConsumerMetrics(); + + private final OptionalLong currentLag; + + public ConsumerMetrics(final OptionalLong currentLag) { + this.currentLag = currentLag; + } + + private ConsumerMetrics(){ + this.currentLag = OptionalLong.empty(); + } + + public static ConsumerMetrics empty(){ Review Comment: This method seems unnecessary, as on the one hand, this class is just a wrapper for the currentLag. If the goal is the support other metrics in the future, it may be less clear what `empty` means. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
