lkuchars commented on PR #10852: URL: https://github.com/apache/nifi/pull/10852#issuecomment-3855425226
> > Instead, it seems better to add a new method to the `KafkaConsumerService` interface, taking a `TopicPartitionSummary` and returning the `OptionalLong` of current lag. There is a balance between simply reproducing Kafka Client methods, but in this case, it seems better to keep the methods distinct. Good point @exceptionfactory. I agree that the new method would be a better fit. But, Instead of using the method to return just the lag I would call this `metrics()` or `kafkaMetrics()`, it has a corresponding method in the `KafkaConsumer` implementation. The new method would return a new object of class `Metrics`, and for now, the metrics returned there would be lag, bytes received, throughput, just a few useful ones. KafkaConsumer collects/computes metrics on poll. Whole list is available here https://kafka.apache.org/41/operations/monitoring/#common-monitoring-metrics-for-producerconsumerconnectstreams WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
