lordgamez commented on code in PR #2099:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2099#discussion_r2781327743
##########
behave_framework/src/minifi_test_framework/steps/core_steps.py:
##########
@@ -36,16 +36,21 @@
@when("all instances start up")
def step_impl(context: MinifiTestContext):
for container in context.containers.values():
- assert container.deploy() or container.log_app_output()
+ assert container.deploy(context)
logging.debug("All instances started up")
@when("the MiNiFi instance starts up")
def step_impl(context: MinifiTestContext):
- assert context.get_or_create_default_minifi_container().deploy()
+ assert context.get_or_create_default_minifi_container().deploy(context)
logging.debug("MiNiFi instance started up")
+@when("the MiNiFi instance is started without assertions")
Review Comment:
Is this step needed? I don't see it being used.
##########
behave_framework/src/minifi_test_framework/containers/container.py:
##########
@@ -74,7 +79,7 @@ def _configure_volumes_of_container_dirs(self):
self._write_content_to_file(file_path, None, content)
self.volumes[temp_path] = {"bind": directory.path, "mode":
directory.mode}
- def deploy(self) -> bool:
+ def deploy(self, context: "Union[MinifiTestContext, None]") -> bool:
Review Comment:
What causes circular import with the syntax change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
