martinzink commented on code in PR #2099:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2099#discussion_r2781644334
##########
behave_framework/src/minifi_test_framework/containers/container.py:
##########
@@ -74,7 +79,7 @@ def _configure_volumes_of_container_dirs(self):
self._write_content_to_file(file_path, None, content)
self.volumes[temp_path] = {"bind": directory.path, "mode":
directory.mode}
- def deploy(self) -> bool:
+ def deploy(self, context: "Union[MinifiTestContext, None]") -> bool:
Review Comment:
With this old syntax the type hint is str and doesnt need actual imports
woth thte new syntax it needs the TestContext imported which includes this
container file iirc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
