lordgamez commented on code in PR #2094:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2094#discussion_r2799187364
##########
core-framework/src/http/HTTPStream.cpp:
##########
@@ -40,30 +40,28 @@ void HttpStream::close() {
}
void HttpStream::seek(size_t /*offset*/) {
- // seek is an unnecessary part of this implementation
throw std::logic_error{"HttpStream::seek is unimplemented"};
}
size_t HttpStream::tell() const {
- // tell is an unnecessary part of this implementation
throw std::logic_error{"HttpStream::tell is unimplemented"};
}
-// data stream overrides
+[[nodiscard]] size_t HttpStream::size() const {
+ throw std::logic_error{"HttpStream::size is unimplemented"};
+}
size_t HttpStream::write(const uint8_t* value, size_t size) {
if (size == 0) return 0;
if (IsNullOrEmpty(value)) {
return io::STREAM_ERROR;
}
- if (!started_) {
- std::lock_guard<std::mutex> lock(mutex_);
- if (!started_) {
- auto callback = std::make_unique<HttpStreamingCallback>();
- http_client_->setUploadCallback(std::move(callback));
- http_client_future_ = std::async(std::launch::async, submit_client,
http_client_);
- started_ = true;
- }
+ std::lock_guard<std::mutex> lock(mutex_);
+ if (!write_started_) {
+ auto callback = std::make_unique<HttpStreamingCallback>();
+ http_client_->setUploadCallback(std::move(callback));
+ http_client_write_future_ = std::async(std::launch::async, submit_client,
http_client_);
+ write_started_ = true;
}
if (auto http_callback =
dynamic_cast<HttpStreamingCallback*>(http_client_->getUploadCallback()))
http_callback->process(value, size);
Review Comment:
Calling the callback process outside the lock would make it possible to
replace the callback from another thread while being read, so it should remain
under the mutex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
