fgerlits commented on code in PR #2094:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2094#discussion_r2799384820
##########
libminifi/include/sitetosite/SiteToSiteClient.h:
##########
@@ -171,6 +172,9 @@ class SiteToSiteClient {
std::atomic<std::chrono::milliseconds> batch_duration_{0s};
std::atomic<std::chrono::milliseconds> timeout_{0s};
+ protected:
Review Comment:
this `protected:` is not needed, we are already in the protected block (same
in `HttpSiteToSiteClient.h`)
but no objection if you want to keep it for clarity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
