szaszm commented on code in PR #2150:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2150#discussion_r3063797226
##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -188,11 +188,11 @@ typedef struct MinifiExtensionCreateInfo {
MinifiStringView version;
void(*deinit)(void* user_data);
void* user_data;
- size_t processors_count;
- const MinifiProcessorClassDefinition* processors_ptr;
} MinifiExtensionCreateInfo;
-MinifiStatus MINIFI_CREATE_EXTENSION_FN(MinifiExtension* extension, const
MinifiExtensionCreateInfo* create_info);
+MinifiExtension* MINIFI_CREATE_EXTENSION_FN(MinifiExtensionContext*
extension_context, const MinifiExtensionCreateInfo* create_info);
Review Comment:
It would be nice to have a comment explaining to readers why this is a macro
##########
libminifi/src/minifi-c.cpp:
##########
@@ -225,37 +225,49 @@ void useCProcessorClassDescription(const
MinifiProcessorClassDefinition& class_d
extern "C" {
-MinifiStatus MinifiCreateExtension(MinifiExtension* extension, const
MinifiExtensionCreateInfo* extension_create_info) {
- gsl_Assert(extension);
+MinifiExtension* MinifiCreateExtension(MinifiExtensionContext*
extension_context, const MinifiExtensionCreateInfo* extension_create_info) {
Review Comment:
I'm thinking maybe we should call this MinifiRegisterExtension, since we're
calling the extension-side code "init", and init normally comes at the same
time or shortly after create.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
