adamdebreceni commented on code in PR #2150:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2150#discussion_r3091756576
##########
libminifi/src/minifi-c.cpp:
##########
@@ -225,37 +225,49 @@ void useCProcessorClassDescription(const
MinifiProcessorClassDefinition& class_d
extern "C" {
-MinifiStatus MinifiCreateExtension(MinifiExtension* extension, const
MinifiExtensionCreateInfo* extension_create_info) {
- gsl_Assert(extension);
+MinifiExtension* MinifiCreateExtension(MinifiExtensionContext*
extension_context, const MinifiExtensionCreateInfo* extension_create_info) {
+ gsl_Assert(extension_context);
gsl_Assert(extension_create_info);
auto extension_name = toString(extension_create_info->name);
minifi::BundleIdentifier bundle{
.name = extension_name,
.version = toString(extension_create_info->version)
};
- auto& bundle_components =
minifi::ClassDescriptionRegistry::getMutableClassDescriptions()[bundle];
- for (size_t proc_idx = 0; proc_idx <
extension_create_info->processors_count; ++proc_idx) {
-
minifi::utils::useCProcessorClassDescription(extension_create_info->processors_ptr[proc_idx],
[&] (const auto& description, const auto& c_class_description) {
-
minifi::core::ClassLoader::getDefaultClassLoader().getClassLoader(extension_name).registerClass(
- c_class_description.name,
- std::make_unique<CProcessorFactory>(extension_name,
toString(extension_create_info->processors_ptr[proc_idx].full_name),
c_class_description));
- bundle_components.processors.emplace_back(description);
- });
- }
- bool success =
reinterpret_cast<org::apache::nifi::minifi::core::extension::Extension*>(extension)->setInfo(org::apache::nifi::minifi::core::extension::Extension::Info{
+ auto* extension =
reinterpret_cast<org::apache::nifi::minifi::core::extension::Extension::Context*>(extension_context)->create(org::apache::nifi::minifi::core::extension::Extension::Info{
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
