exceptionfactory commented on code in PR #11129: URL: https://github.com/apache/nifi/pull/11129#discussion_r3074543766
########## nifi-framework-bundle/nifi-framework/nifi-client-dto/src/test/java/org/apache/nifi/web/api/dto/util/TestDateTimeAdapter.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api.dto.util; + +import org.junit.jupiter.api.Test; + +import java.time.Instant; +import java.util.Date; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class TestDateTimeAdapter { + + private static final String TEST_DATE_TIME = "2026-01-02T03:04:56Z"; + + @Test + public void testMarshal() throws Exception { + DateTimeAdapter adapter = new DateTimeAdapter(); + Date date = Date.from(Instant.parse(TEST_DATE_TIME)); Review Comment: It would be helpful to avoid the intermediate parsing to an `Instant`. Instead, using the `new Date(long)` constructor should provide a more narrow approach to construct a Date with a given value. ########## nifi-framework-bundle/nifi-framework/nifi-client-dto/src/test/java/org/apache/nifi/web/api/dto/util/TestDateTimeAdapter.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.web.api.dto.util; + +import org.junit.jupiter.api.Test; + +import java.time.Instant; +import java.util.Date; + +import static org.junit.jupiter.api.Assertions.assertEquals; + +public class TestDateTimeAdapter { + + private static final String TEST_DATE_TIME = "2026-01-02T03:04:56Z"; + + @Test + public void testMarshal() throws Exception { + DateTimeAdapter adapter = new DateTimeAdapter(); + Date date = Date.from(Instant.parse(TEST_DATE_TIME)); + assertEquals(date, adapter.unmarshal(adapter.marshal(date))); Review Comment: This is testing both `marshal` and `unmarshal` in one call. Instead, there should be an expected static final string value, matching the `long` timestamp. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
