superdachuan commented on PR #11129: URL: https://github.com/apache/nifi/pull/11129#issuecomment-4265010620
@exceptionfactory Thanks for the review and helpful suggestions. I updated the tests accordingly. My original intent in combining `marshal` and `unmarshal` was to verify round-trip consistency, since the adapter output includes a time zone and I initially wanted to avoid relying on a single fixed string. I have kept that intent as explicit round-trip tests, and also added more direct assertions for multiple time zones. I had originally avoided temporarily switching the default time zone because I was concerned about affecting other tests. After reviewing similar patterns in the codebase, I updated this test to verify behavior across multiple time zones directly. One detail here is that `DateTimeAdapter` initializes its `DateTimeFormatter` during class loading with `ZoneId.systemDefault()`, so changing the default time zone later does not update the formatter. For that reason, the multi-time-zone assertions reload `DateTimeAdapter` with a dedicated `ClassLoader` instead of reusing the default adapter instance from this test class. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
