szaszm commented on code in PR #2155: URL: https://github.com/apache/nifi-minifi-cpp/pull/2155#discussion_r3085389083
########## cmake/Couchbase.cmake: ########## @@ -30,18 +30,26 @@ set(COUCHBASE_CXX_CLIENT_BUILD_TOOLS OFF CACHE BOOL "" FORCE) set(COUCHBASE_CXX_CLIENT_POST_LINKED_OPENSSL ON CACHE BOOL "" FORCE) set(COUCHBASE_CXX_CLIENT_INSTALL OFF CACHE BOOL "" FORCE) +# Fix for MSVC + ASIO C++20/23 concept evaluation bugs +if(MSVC) + add_compile_definitions(ASIO_DISABLE_CONCEPTS) + # Ensure Windows 10 API target so ASIO networking features are fully enabled + add_compile_definitions(_WIN32_WINNT=0x0A00) Review Comment: Does this mean dropping pre-win10 windows versions? That's something that I would consider carefully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
