szaszm commented on code in PR #2155:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2155#discussion_r3087225066
##########
extensions/couchbase/CMakeLists.txt:
##########
@@ -21,20 +21,21 @@ if (NOT (ENABLE_ALL OR ENABLE_COUCHBASE))
return()
endif()
-if (WIN32)
- include(Couchbase_1_0_2)
-else()
- include(Couchbase)
-endif()
+include(Couchbase)
include(${CMAKE_SOURCE_DIR}/extensions/ExtensionHeader.txt)
file(GLOB SOURCES "*.cpp" "controllerservices/*.cpp" "processors/*.cpp")
add_minifi_library(minifi-couchbase SHARED ${SOURCES})
-target_include_directories(minifi-couchbase PRIVATE BEFORE
"${CMAKE_CURRENT_SOURCE_DIR}" "controllerservices" "processors"
${COUCHBASE_INCLUDE_DIR})
-target_link_libraries(minifi-couchbase ${LIBMINIFI}
couchbase_cxx_client_static hdr_histogram_static snappy llhttp::llhttp)
+target_include_directories(minifi-couchbase PRIVATE BEFORE
"${CMAKE_CURRENT_SOURCE_DIR}" "controllerservices" "processors")
+target_include_directories(minifi-couchbase SYSTEM PRIVATE
${COUCHBASE_INCLUDE_DIR})
+# Demote preprocessor warnings so <ciso646> doesn't break the build
+if (CMAKE_CXX_COMPILER_ID MATCHES "GNU")
+target_compile_options(minifi-couchbase PRIVATE -Wno-error=cpp)
Review Comment:
```suggestion
target_compile_options(minifi-couchbase PRIVATE -Wno-error=cpp)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]