martinzink commented on code in PR #2096:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2096#discussion_r3152765645
##########
libminifi/src/minifi-c.cpp:
##########
@@ -146,6 +151,37 @@ class CProcessorFactory : public
minifi::core::ProcessorFactory {
minifi::utils::CProcessorClassDescription class_description_;
};
+class CControllerServiceFactory : public
minifi::core::controller::ControllerServiceFactory {
+ public:
+ CControllerServiceFactory(std::string group_name, std::string class_name,
minifi::utils::CControllerServiceClassDescription class_description)
+ : group_name_(std::move(group_name)),
+ class_name_(std::move(class_name)),
+ class_description_(std::move(class_description)) {}
Review Comment:
why?
the google style guide allows it
https://google.github.io/styleguide/cppguide.html#Constructor_Initializer_Lists
and .clang_format AllowShortFunctionsOnASingleLine explictly formats these like
this
if u disagree i suggest we chagne these and the clang formatter in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
