szaszm commented on code in PR #2096:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2096#discussion_r3153585089
##########
libminifi/src/minifi-c.cpp:
##########
@@ -146,6 +151,37 @@ class CProcessorFactory : public
minifi::core::ProcessorFactory {
minifi::utils::CProcessorClassDescription class_description_;
};
+class CControllerServiceFactory : public
minifi::core::controller::ControllerServiceFactory {
+ public:
+ CControllerServiceFactory(std::string group_name, std::string class_name,
minifi::utils::CControllerServiceClassDescription class_description)
+ : group_name_(std::move(group_name)),
+ class_name_(std::move(class_name)),
+ class_description_(std::move(class_description)) {}
Review Comment:
I'd like to have at least the empty line between this ctor and the next
thing, because currently they visually blend in the file. I don't insist on
moving the braces, tho I would never put them there like that myself.
To be clear, I don't want empty lines between all constructors or no
constructors, but I think multi line blocks like this constructor definition
need a bit of margin around them to better separate them from the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
