martinzink commented on code in PR #2152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2152#discussion_r3159167470


##########
libminifi/test/libtest/unit/TestBase.cpp:
##########
@@ -360,6 +360,27 @@ minifi::Connection* 
TestPlan::addConnection(minifi::core::Processor* source_proc
   return retVal;
 }
 
+std::shared_ptr<minifi::core::controller::ControllerServiceNode> 
TestPlan::addController(const std::string& name, const 
std::shared_ptr<core::controller::ControllerService>& cs) {

Review Comment:
   it will be used in #2153 and later on, we need this because we would like to 
instantiate them with preexisting (instantiated through the API) controller 
services
   
   
https://github.com/apache/nifi-minifi-cpp/pull/2153/changes#diff-d5f59e4f9d39633968dfdf29d96503d484179de5c8b66f72a0df9340745f3354R56-R62



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to