martinzink commented on code in PR #2152:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2152#discussion_r3159365467
##########
extension-framework/cpp-extension-lib/include/api/core/Resource.h:
##########
@@ -145,4 +150,43 @@ void useProcessorClassDescription(Fn&& fn) {
fn(description);
}
+template<typename Class, typename Fn>
+void useControllerServiceClassDescription(Fn&& fn) {
+ std::vector<std::vector<MinifiStringView>> string_vector_cache;
+
+ const auto full_name = minifi::core::className<Class>();
+
+ std::vector<MinifiPropertyDefinition> class_properties =
utils::toProperties(Class::Properties, string_vector_cache);
+
+ MinifiControllerServiceClassDefinition description{.full_name =
utils::toStringView(full_name),
Review Comment:
agreed, i went with definition everywhere because the class already contains
description so it made more sense for me
[useProcessorClassDescription ->
useProcessorClassDefinition](https://github.com/apache/nifi-minifi-cpp/pull/2152/commits/97c898aac7001f4abd67a16b35f0f69f181c55be)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
