pvillard31 commented on code in PR #11314:
URL: https://github.com/apache/nifi/pull/11314#discussion_r3398749019
##########
nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-services/src/main/java/org/apache/nifi/snowflake/service/StandardSnowflakeIngestManagerProviderService.java:
##########
@@ -213,6 +228,46 @@ public void migrateProperties(PropertyConfiguration
config) {
config.renameProperty(SnowflakeProperties.OLD_SCHEMA_PROPERTY_NAME,
SnowflakeProperties.SCHEMA.getName());
}
+ private ProxySelector buildProxySelector(final ProxyConfigurationService
proxyConfigurationService) {
+ if (proxyConfigurationService == null) {
+ return null;
+ }
+ final Proxy proxy =
proxyConfigurationService.getConfiguration().createProxy();
Review Comment:
Could we use ProxyConfiguration.getConfiguration(context), which returns
DIRECT when the service is unset, and ProxyConfiguration.hasCredential() to
simplify this code and remove the two null returning helper methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
