rakesh-rsky commented on code in PR #11314:
URL: https://github.com/apache/nifi/pull/11314#discussion_r3402870348
##########
nifi-extension-bundles/nifi-snowflake-bundle/nifi-snowflake-services/src/test/java/org/apache/nifi/snowflake/service/SnowpipeIngestClientTest.java:
##########
@@ -264,6 +266,31 @@ void testGetInsertReportErrorResponse() {
assertTrue(exception.getMessage().contains(String.valueOf(HttpURLConnection.HTTP_INTERNAL_ERROR)));
}
+ @Test
+ void testInsertFilesViaProxy() throws InterruptedException,
NoSuchAlgorithmException {
Review Comment:
I've updated the proxy test, it now points the base URI to a different host
(http://fake-snowflake.example.com) while the proxy selector points to
MockWebServer. When Java's HttpClient routes through an HTTP proxy, it sends
the request target in absolute form, so we assert the recorded request starts
with http://fake-snowflake.example.com. This proves the proxy selector is
actually being used. For the HTTPS + credentials case as mentioned in the
comment above, this hits the JDK limitation with CONNECT tunneling and would
need a full TLS proxy setup to test properly, which is more of an integration
test scenario. The property description now documents what users need to
configure to make it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
