lordgamez commented on code in PR #2212:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2212#discussion_r3541980068
##########
CMakeLists.txt:
##########
@@ -314,13 +319,17 @@ endif()
if (STRICT_GSL_CHECKS STREQUAL "DEBUG_ONLY")
list(APPEND GslDefinitions
$<$<NOT:$<CONFIG:Debug>>:${GslDefinitionsNonStrict}>)
endif()
-target_compile_definitions(gsl-lite INTERFACE ${GslDefinitions})
-# date
-include(Date)
+get_target_property(_gsl_lite_real_target gsl-lite::gsl-lite ALIASED_TARGET)
+if (NOT _gsl_lite_real_target)
+ set(_gsl_lite_real_target gsl-lite::gsl-lite)
+endif()
+target_compile_definitions(${_gsl_lite_real_target} INTERFACE
${GslDefinitions})
Review Comment:
gsl-lite::gsl-lite is created in the FetchContent_MakeAvailable(gsl-lite)
call, it is guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
