martinzink commented on code in PR #2212:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2212#discussion_r3545440028
##########
conanfile.py:
##########
@@ -21,15 +37,62 @@ class MiNiFiCppMain(ConanFile):
name = "minifi-cpp"
version = "1.0.0"
license = "Apache-2.0"
- requires = shared_requires
settings = "os", "compiler", "build_type", "arch"
generators = "CMakeDeps"
- options = {"shared": [True, False], "fPIC": [True, False]}
+ options = {"shared": [True, False], "fPIC": [True, False],
"custom_malloc": [False, "jemalloc", "mimalloc", "rpmalloc"], "enable_all":
[True, False], "enable_rocksdb": [True, False],
+ "enable_sftp": [True, False], "enable_prometheus": [True,
False], "enable_bzip2": [True, False], "enable_lzma": [True, False],
"enable_mqtt": [True, False],
+ "enable_couchbase": [True, False], "enable_kafka": [True,
False], "enable_opc": [True, False], "skip_tests": [True, False]}
- default_options = {"shared": False, "fPIC": True}
+ default_options = {"shared": False, "fPIC": True, "custom_malloc": False,
"enable_all": False, "enable_rocksdb": False, "enable_sftp": False,
"enable_prometheus": False, "enable_bzip2": False,
+ "enable_lzma": False, "enable_mqtt": False,
"enable_couchbase": False, "enable_kafka": False, "enable_opc": False,
"skip_tests": False}
exports_sources = shared_sources
+ def requirements(self):
+ for req in shared_requires:
+ self.requires(req)
+ self.requires("lua/5.4.8", force=True)
+ self.requires("asio/1.38.0", force=True)
+ self.requires("lz4/1.10.0", force=True)
+ if self.options.enable_all or self.options.enable_rocksdb:
+ self.requires("rocksdb/11.1.1@minifi/develop")
+ if self.options.enable_all or self.options.enable_sftp:
+ self.requires("libssh2/1.11.1")
+ if self.options.enable_all or self.options.enable_prometheus:
+ self.requires("prometheus-cpp/1.3.0")
+ if self.options.enable_all or self.options.enable_bzip2:
+ self.requires("bzip2/1.0.8")
+ if self.options.enable_all or self.options.enable_lzma:
+ self.requires("xz_utils/5.8.3")
Review Comment:
not relevant here just to keep in mind, i think we should try to move
towards `MINIFI_FOO` instead of `ENABLE_FOO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
