maltesander commented on code in PR #11391:
URL: https://github.com/apache/nifi/pull/11391#discussion_r3563236113
##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-parquet-writer/src/test/java/org/apache/nifi/services/iceberg/parquet/ParquetIcebergWriterTest.java:
##########
@@ -194,6 +196,43 @@ void testWriteDataFilesPartitionedTimestamp() throws
IOException {
assertEquals(microsecondsExpected, partitionField);
}
+ @Test
+ void testWriteDataFilesComplexTypes() throws IOException {
+ runner.enableControllerService(parquetIcebergWriter);
+
+ final Types.StructType nestedStruct = Types.StructType.of(
+ Types.NestedField.optional(10, "city", Types.StringType.get())
+ );
+ final Schema schema = new Schema(
+ Types.NestedField.required(1, "id", Types.StringType.get()),
+ Types.NestedField.optional(2, "tags",
+ Types.ListType.ofOptional(3, Types.StringType.get())),
+ Types.NestedField.optional(4, "address", nestedStruct),
+ Types.NestedField.optional(5, "attributes",
+ Types.MapType.ofOptional(6, 7, Types.StringType.get(),
Types.StringType.get()))
+ );
Review Comment:
Moved hardcoded constants to static ones:
https://github.com/apache/nifi/pull/11391/commits/ef3e162af7aa479ecba4c318428a8ba3c8ff5704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
