maltesander commented on PR #11391: URL: https://github.com/apache/nifi/pull/11391#issuecomment-5435062952
> Thanks for your patience @maltesander. I'm open to addressing the multiple timestamp types in this pull request, but deferring it to a separate issue also works. > > I noted a few remaining minor recommendations. No worries. Tried to adapt to the review: - removed early returns - added missing method header comments for parameters and return values I pushed the timestamp changes here https://github.com/apache/nifi/pull/11391/commits/270dc35ba3b33a3da6e4fe684986b1c9952a1a67 and added it to the PR description (not the jira ticket). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
