exceptionfactory commented on PR #11599: URL: https://github.com/apache/nifi/pull/11599#issuecomment-5481504220
By module for extension, I was referring specifically to `NiFiSystemIT` as a base test class that others would extend. The other remaining `public` classes also imply the need for reuse. That's based on the usage in existing system tests. Is there a different way that system test builders would use this module? At the root, I'm concerned about the lack of encapsulation in the current approach. The design has worked well when everything was co-located in the system test suite, but it seems like just moving out these classes doesn't provide the kind of approach needed for test interfaces versus test implementation. Taking a different perspective, it also raises a question as to whether a Testcontainer approach might be better, as that would encapsulate the entire application, without these types of module contract concerns. I realize this is a significantly different path, but it seems worth considering as an alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
