markap14 commented on PR #11599: URL: https://github.com/apache/nifi/pull/11599#issuecomment-5485373796
Ahh I see what you're saying now @exceptionfactory. I don't think Testcontainers is really the way we want to go here because that would require that the full docker image be built so it could be usable. That would absolutely make sense for testing extensions such as Processors in a separate service (by uploading the nar, etc). But it wouldn't work for framework-level extensions. That said, I reviewed the pom.xml again and I think I see the concern. With the latest commit we now have basically only 2 sets of dependencies: - Those on the nifi root lib/ directory (these are necessary) to start the nifi instance - The nifi-toolkit-client necessary for communicating with the nifi instance. This includes the jersey dependency. An argument can definitely be made that it's actually a bug in the toolkit-client code that it's not explicitly defined there, but it's necessary at runtime. The pom that I had factored out did have a few extra dependencies that I was able to eliminate with some simple refactoring: - nifi-per-process-group-logging (not actually needed in the 'framework' module, just the test that uses it) - commons-lang3, nifi-xml-processing (not actually necessary for the 'framework' module either) - nifi-framework-cluster-protocol (used by the framework module but it was just for access to enums to compare to DTO String values, etc. so I was able to do some very simple minor refactoring to eliminate the dependency). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
