mattcasters opened a new pull request, #11660: URL: https://github.com/apache/nifi/pull/11660
# Summary [NIFI-16326](https://issues.apache.org/jira/browse/NIFI-16326) Subsequent Parameter Context inheritance changes do not update effective parameter values. The first inheritance change on a Parameter Context (reorder, add, or remove) updates effective values as expected. Later inheritance changes update the configured inheritance list, but NiFi continues using the value that became effective after the first change. Process Groups and components bound to that context see the same stale value. This happens because Parameter Context update analysis injects effective inherited Parameter DTOs into the request so referencing components can be identified. Those DTOs were persisted as local Parameters whenever `inherited` was not explicitly `true`. A local Parameter then shadows inheritance, so later reorders and add/remove operations cannot change the effective value. `StandardParameterContextDAO.getParameters()` now omits inherited Parameters from local persistence when: - `inherited` is `true`, or - `inherited` is unset and the Parameter's source context is not the context being updated An explicit local override (`inherited=false`) is still accepted. Coverage includes unit tests for repeated reorder and add/remove on `StandardParameterContext`, DAO tests for injected effective Parameters with and without the `inherited` flag, and system tests that replay the Jira reproduction through the REST update API. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-16326) issue created ### Pull Request Tracking - Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - Pull Request based on current revision of the `main` branch - Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] `./mvnw -P contrib-check -DskipTests package` completed on the changed modules and their reactor dependencies (JDK 21) - [x] JDK 21 - [ ] JDK 25 - Unit tests: `TestStandardParameterContext` (inheritance reorder/add-remove), `TestStandardParameterContextDAO` (11 tests) ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
