szaszm commented on PR #2261: URL: https://github.com/apache/nifi-minifi-cpp/pull/2261#issuecomment-5638744736
Since the clear function operates with UA_NodeId, I would treat the internals as a black box for the purpose of cleanup, and always call UA_NodeId_clear on it, regardless of the union values. I'd treat UA_NodeId as a resource handle and UA_NodeId_clear its corresponding resource cleanup function, and resource handles can be owning or non-owning, that's why I think we should use gsl::owner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
